Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RedisConcurrencyRateLimiter should use async Redis call to release the lease #8

Open
cristipufu opened this issue Nov 6, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@cristipufu
Copy link
Owner

dotnet/runtime#77669

private void Release(ConcurencyLeaseContext leaseContext)
{
    var database = _connectionMultiplexer.GetDatabase();
    // how to use async? if only RateLimitLease would implement IAsyncDisposable
    database.SortedSetRemove($"rl:{_partitionKey}", leaseContext.RequestId);
}
@cristipufu cristipufu added the enhancement New feature or request label Nov 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants
@cristipufu and others