Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add UI test #1037

Open
Emilgardis opened this issue Sep 29, 2022 · 2 comments · May be fixed by #1115
Open

Add UI test #1037

Emilgardis opened this issue Sep 29, 2022 · 2 comments · May be fixed by #1115
Assignees
@Alexhuszagh
Labels
enhancement meta issues/PRs related to the maintenance of the crate.
Milestone
v0.3.1

Comments

@Emilgardis
Copy link
Member

We should consider using UI tests to the CI/tests ala snapbox or trycmd

this would help catch unexpected changes to output that don't necessarily cause the build to error.
@Alexhuszagh
Copy link
Contributor

Alexhuszagh commented Nov 5, 2022 •
edited
Loading

I think assert_cmd might be the proper tool for the job here:
https://crates.io/crates/assert_cmd

Edit: trycmd is probably better, and I'll try to configure it entirely tomorrow.

@Alexhuszagh Alexhuszagh self-assigned this Nov 5, 2022
@Alexhuszagh Alexhuszagh added the meta issues/PRs related to the maintenance of the crate. label Nov 5, 2022
@Alexhuszagh Alexhuszagh linked a pull request Nov 5, 2022 that will close this issue
Draft
8 tasks
@Alexhuszagh
Copy link
Contributor

I think some variant of this should be finished prior to 0.3.0, just to avoid any regressions during our next release.

@Alexhuszagh Alexhuszagh added this to the v0.3.0 milestone Nov 12, 2022
@Emilgardis Emilgardis mentioned this issue Feb 12, 2023
Merged
@Emilgardis Emilgardis mentioned this issue Jan 29, 2024
Merged
@Emilgardis Emilgardis modified the milestones: v0.3.0, v0.3.1 Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Alexhuszagh Alexhuszagh

Labels
enhancement meta issues/PRs related to the maintenance of the crate.
Projects
None yet
Milestone
v0.3.1
Development

Successfully merging a pull request may close this issue.

Initial version of UI tests. Alexhuszagh/cross
2 participants
@Emilgardis @Alexhuszagh