Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't use custom docker image? #109

Closed
jD91mZM2 opened this issue Jun 16, 2017 · 3 comments
Closed

Can't use custom docker image? #109

jD91mZM2 opened this issue Jun 16, 2017 · 3 comments

Comments

@jD91mZM2
Copy link

jD91mZM2 commented Jun 16, 2017

I have this Cargo.toml:

[package]
name = "play-youtube"
version = "0.1.0"
authors = ["LEGOlord208 <LEGOlord208@krake.one>"]

[dependencies]
# dependencies here

[target.x86_64-unknown-linux-gnu]
image = "play-youtube"

I have the play-youtube docker image with the latest tag.

Using cross build --release -v --target x86_64-unknown-linux-gnu,
I just see that it doesn't use the image - AND it prints
warning: unused manifest key: target.x86_64-unknown-linux-gnu.image

Help?

EDIT: s/cargo build/cross build

@Emilgardis
Copy link
Member

Hello Legolord! Nice to see you trying to use cross.

So, the image tag is supposed to go into Cross.toml, not Cargo.toml.
https://github.com/japaric/cross#custom-docker-images

Also, you'll have to run cross build --release --target x86_64-unknown-linux-gnu so that you actually launch cross. Hopefully that fixes things.

@jD91mZM2
Copy link
Author

jD91mZM2 commented Jun 17, 2017

Ohh! That makes sense! Nice to see it's a separate config. Sorry for not reading carefully enough.
Thanks for your help!

(Though, cargo build was a typo. I meant cross build there.)

@Alexhuszagh
Copy link
Contributor

This was much more satisfactorily implemented in #678.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants