Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace build-docker-image.sh with GHA actions #697

Open
Emilgardis opened this issue Apr 23, 2022 · 3 comments
Open

Replace build-docker-image.sh with GHA actions #697

Emilgardis opened this issue Apr 23, 2022 · 3 comments
Labels
enhancement

Comments

@Emilgardis
Copy link
Member

Emilgardis commented Apr 23, 2022 •
edited
Loading

See #609 (comment)
@Alexhuszagh
Copy link
Contributor

Alexhuszagh commented May 28, 2022 •
edited
Loading

Is this a good idea? It's quite useful to build locally to test image changes without having to push to a repository on every build.

@Alexhuszagh
Copy link
Contributor

I think this has been correctly done with xtask, and having additional configurations with GHA actions, but also allowing local builds quite easily?

@Emilgardis
Copy link
Member Author

with #849 this would be complete, it's probably the best way to support it. We could either supply the bake meta to a gh action, or directly invoke it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Emilgardis @Alexhuszagh