Merge #332

bors[bot] · Stjepan Glavina · bors[bot] · commit dc37ed89fb77 · 2019-02-22T08:11:16.000Z
332: Deprecate AtomicCell::get_mut r=stjepang a=stjepang This is an essential step in solving #315 - there is no way to make `AtomicCell::get_mut()` sound, unfortunately. Let's deprecate it and remove in the next release. Co-authored-by: Stjepan Glavina <stjepang@gmail.com>
diff --git a/crossbeam-utils/src/atomic/atomic_cell.rs b/crossbeam-utils/src/atomic/atomic_cell.rs
@@ -57,6 +57,8 @@ impl<T> AtomicCell<T> {
     ///
     /// assert_eq!(a.load(), 8);
     /// ```
+    #[doc(hidden)]
+    #[deprecated(note = "this method is unsound and will be removed in the next release")]
     pub fn get_mut(&mut self) -> &mut T {
         unsafe { &mut *self.value.get() }
     }

Original file line number	Diff line number	Diff line change
`@@ -57,6 +57,8 @@ impl<T> AtomicCell<T> {`
`57`	`57`	`///`
`58`	`58`	`/// assert_eq!(a.load(), 8);`
`59`	`59`	/// ```
	`60`	`+ #[doc(hidden)]`
	`61`	`+ #[deprecated(note = "this method is unsound and will be removed in the next release")]`
`60`	`62`	`pub fn get_mut(&mut self) -> &mut T {`
`61`	`63`	`unsafe { &mut *self.value.get() }`
`62`	`64`	`}`