Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish knip setup #500

Open
mdirolf opened this issue Apr 26, 2024 · 0 comments
Open

Finish knip setup #500

mdirolf opened this issue Apr 26, 2024 · 0 comments

Comments

@mdirolf
Copy link
Member

mdirolf commented Apr 26, 2024

I started setting up knip and it did manage to find a couple of files that were completely dead. It seems possible that removing unused exports might cascade to some more code elimination. We should also try to get this into CI once we have it "passing" against the current codebase.

It can be run with yarn knip. There are some dependency issues listed many of which I'm willing to believe should be changed, though some seem like false alerts we should sort (the lingui stuff, for example, is actually used I think). The main false alert I'd like to figure out, though, is doGlicko which is listed in unused exports but I know is imported in function/src/index.ts (which I thought I successfully added to the list of entrypoints.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant