Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DNSConfig support for GKE Clusters #464

Closed
jensentanlo opened this issue Sep 28, 2022 · 2 comments · Fixed by #470
Closed

Add DNSConfig support for GKE Clusters #464

jensentanlo opened this issue Sep 28, 2022 · 2 comments · Fixed by #470
Assignees
Labels
enhancement New feature or request

Comments

@jensentanlo
Copy link
Contributor

What problem are you facing?

Currently this field is not exposed in the cluster spec.
When I pulled the repo, I noticed that the gcp go client version is quite old and is missing this field, so we'd need to upgrade the client but it's there in the newer versions of the client.

Relevant REST doc for the field:
https://cloud.google.com/kubernetes-engine/docs/reference/rest/v1/projects.locations.clusters#Cluster.DNSConfig

How could Crossplane help solve your problem?

It would be great if this field could be added.

@jensentanlo jensentanlo added the enhancement New feature or request label Sep 28, 2022
@jensentanlo
Copy link
Contributor Author

Just a note but I'll be tackling this (if this feature is okay to add)

@Feggah
Copy link
Collaborator

Feggah commented Sep 28, 2022

Thanks for raising this issue, @jensentanlo!

Go for it 🙂 feel free to ask for my review when you open the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants