Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composed resources are still claimable #177

Closed
muvaf opened this issue Apr 30, 2020 · 1 comment · Fixed by #175
Closed

Composed resources are still claimable #177

muvaf opened this issue Apr 30, 2020 · 1 comment · Fixed by #175

Comments

@muvaf
Copy link
Member

muvaf commented Apr 30, 2020

What problem are you facing?

Claims bind to resources whose binding status is Unbound and composed resources never become Bound

How could Crossplane help solve your problem?

Composed resources shouldn't be claimed by others.

@negz
Copy link
Member

negz commented May 7, 2020

Any managed resources that are composed into a composite will have their controller reference set to point to the composite. I don't think there's ever a situation where a managed resource with a controller reference is a valid target for a claim that sets an explicit resourceRef, so perhaps we could solve this by adding a check to the claim binding Bind() methods that refuses to bind to a managed resource with a non-nil controller reference.

@negz negz transferred this issue from crossplane/crossplane May 7, 2020
@negz negz closed this as completed in #175 May 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants