Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Target smaller interfaces #4

Open
negz opened this issue Oct 4, 2019 · 1 comment
Open

Target smaller interfaces #4

negz opened this issue Oct 4, 2019 · 1 comment
Labels
enhancement New feature or request wontfix This will not be worked on

Comments

@negz
Copy link
Member

negz commented Oct 4, 2019

What problem are you facing?

crossplane-runtime interfaces like resource.Managed are composed of other, more tightly scoped interfaces such as resource.ClassReferencer. angryjet currently targets the broader interfaces; it will generate the resource.Managed method set for types that are support the entire functionality of resource.Managed, or it will generate nothing. This means types like Azure storage containers that look almost but not quite like a managed resource (due to missing embedded ResourceSpec) get no generated methods, despite being capable of satisfying many of the interfaces that resource.Managed is composed from.

How could Crossplane help solve your problem?

angryjet could detect the potential to satsify, and generate the methods of, smaller interfaces like resource.ClassReferencer rather than broad interfaces like resource.Managed. This may require some thought as to what files the (generally 1-2) getters and setters of these interfaces would be written to.

@negz negz added the enhancement New feature or request label Oct 4, 2019
@stale
Copy link

stale bot commented Aug 13, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Aug 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

1 participant