Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TRACE-level logging #611

Closed
suskin opened this issue Jul 29, 2019 · 1 comment
Closed

TRACE-level logging #611

suskin opened this issue Jul 29, 2019 · 1 comment
Labels
enhancement New feature or request

Comments

@suskin
Copy link
Member

suskin commented Jul 29, 2019

This is somewhat related to #331 . I was working with crossplane and the wordpress gcp example locally, and was wanting more detail in the logs for debugging issues (such as the issue described in #597). But, the information to debug this type of issue seems like it's at an even more verbose level than logging.Debug, which is the only level we support now.

I feel it would make sense to create another logging level, logging.Trace, which could be used for extra-verbose debug statements. An example of a statement at Trace could be "syncing of the cache instance is done because it hasn't been created yet", and other messages about enter and exit conditions.

What do other folks think? Does this seem like a good idea? /cc @jbw976 @negz

@suskin suskin added enhancement New feature or request logs labels Jul 29, 2019
@negz
Copy link
Member

negz commented Jan 24, 2020

My current thinking is to avoid this, somewhat explained by the logging package doc in crossplane/crossplane-runtime#108. I agree debug logging is important, but I think it should be an on or off thing - not at multiple levels. Please comment on that pull if you disagree!

@negz negz closed this as completed Jan 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants