call ApplyTFConversions in Update function from terraform plugin sdk external client #440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…external client because it was causing unmarshalling errors. Signed-off-by: digna-ionos <darius-andrei.igna@ionos.com>
digna-ionos
requested review from
ulucinar,
sergenyalcin,
erhancagirici and
mergenci
as code owners
|
@digna-ionos, Can you share details of your use case that required this change? While I agree that this change is likely to be required, the fact that we haven't hit an issue for so long makes me doubt — and the impact of this change doesn't help relieve my doubt 🙂 I would be happy if you could provide more details. If you could also provide an example manifest that fails before the change and passes after, it would even be better. |
|
@mergenci I've prepared two tests to make it simpler to understand and play with it if you need. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not calling ApplyTFConversions in Udate function of tf plugin sdk external client was causing unmarshalling errors for singleton lists.
Description of your changes
add ApplyTFConversions call in Update function, after marshalling json state and before setting the observation.
Fixes #438
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
There are already tests in place for Update function.