-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proper solution to figure out terminal size inside of a subshell #419
Comments
@purpleP I am getting a bit tired of the way you are communicating even after this was made clear and we ignored those bad communication styles. I think we all agreed on the fact that the subprocess call is a bad idea however you keep the sticking finger up. We are here to work on a solution, and we do this all in our free time, it is not only your precious time. I will not discuss further here. Anyhow, I open a new issue, delete this whole issue and go on with @sharnoff his last comment. And suggest not to comment there unless you really want to help and get this part improved. At least thanks for bringing it up. New issue: #422 |
My recent investigation about my binary size have led me to the fact that crossterm wastes 10K to call tput to determine terminal size in a subshell.
I've found the discussion.
It hurts my feelings that such things are merged into master especially without even tracking issue to make proper solution.
I've created a question to debug tput inside of a subshell.
@Canop when running inside gdb it should count as a subshell, right?
It seems like
tput
isn't doing anything except invokingioctl
.Have anyone built minimal reproducible example using ioctl which gives incorrect answer in a subshell? Is there a test that shows that it doesn't work?
The text was updated successfully, but these errors were encountered: