-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support mintty under Windows #473
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
terminal::size()
reports incorrect terminal dimensions (80, 25 - the default Windows cmd dimensions) when launching from a mintty instance, presumably becausecrossterm/src/terminal/sys/windows.rs
only uses native Console api functions?Other commands/features might also be affected, I haven't done extensive tests (though at least basic commands like coloring and cursor positioning seem to work properly).
Describe the solution you'd like
The code in
crossterm/src/terminal/sys/windows.rs
should include checks/code for non-native Windows consoles where necessary in order to ensure proper results when using such terminals.Additional context
I put this as a feature request since mintty wasn't listed under the "Tested Terminals" list.
edit: Just noticed that non-ascii characters are also not properly displayed in mintty, example
tästÜng croßter€
displaystästÜng croßter€
(is displayed correctly in cmd/Powershell)The text was updated successfully, but these errors were encountered: