Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support bitflags version 2 #770

Closed
dzfrias opened this issue Mar 28, 2023 · 0 comments · Fixed by #777
Closed

Support bitflags version 2 #770

dzfrias opened this issue Mar 28, 2023 · 0 comments · Fixed by #777

Comments

@dzfrias
Copy link

dzfrias commented Mar 28, 2023

Is your feature request related to a problem? Please describe.
Bitflags v2 provides a ton of conveniences for types implementing Bitflags. Currently, both the KeyModifiers and KeyboardEnhancementFlags types use the bitflags! macro. It would be nice to use version 2 so their APIs get access to the new features.

This includes a few breaking changes, so there a couple ways to handle it.

Let me know if you want me to submit a PR for any of the options!

Describe the solution you'd like
Use Bitflags v2 for the KeyModifiers and KeyboardEnhancementFlags types. This would require an increment of the minor version of this crate.

Describe alternatives you've considered if any
Either to not go through with this change or gate it with a feature flag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant