Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

500 after middle button clicking on a video in leaderboard #243

Closed
AdamStelmaszczyk opened this issue Jul 6, 2017 · 3 comments
Closed

Comments

@AdamStelmaszczyk
Copy link

AdamStelmaszczyk commented Jul 6, 2017

After middle button clicking (which opens a link in a new tab) on any video image on leaderboard page, 500 "We're sorry, but something went wrong" page always comes up, example.

Left button clicking works (because it only opens the modal window, no URL change).

@AdamStelmaszczyk AdamStelmaszczyk changed the title 500 after clicking on a video in leaderboard 500 after middle button clicking on a video in leaderboard Jul 6, 2017
@scarroll32 scarroll32 self-assigned this Jul 22, 2017
@scarroll32 scarroll32 added the bug label Aug 21, 2017
@marcelsalathe
Copy link

Is this still an issue? Which middle button do you mean?

@AdamStelmaszczyk
Copy link
Author

I just tried middle button clicking on video, yes, it's still an issue.

With mouses with roll and 2 buttons, pressing the roll acts as a middle button click:
https://teamlife.byu.edu/Portals/41/images/tips/mouse-middle-click.png

@scarroll32
Copy link
Contributor

The middle button opens the link in a new tab. This doesn't really work for a modal, which should be attached the to parent. New behaviour: middle button opens the leaderboard in a new tab. Existing right click on the video opens the modal.

Thanks for the contribution @AdamStelmaszczyk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants