Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post challenge flag is set for create only #332

Closed
scarroll32 opened this issue Sep 29, 2017 · 3 comments
Closed

Post challenge flag is set for create only #332

scarroll32 opened this issue Sep 29, 2017 · 3 comments

Comments

@scarroll32
Copy link
Contributor

The post challenge flag should only be set when a submission is created, not when it is later updated for a regrade.

https://github.com/crowdAI/crowdai/blob/master/app/models/submission.rb

@spMohanty
Copy link
Member

spMohanty commented Sep 29, 2017

Also, we need to rethink how to visually show post-challenge submissions.
I will add this to the discussion on Monday with Jason, if we have some extra time at the end.

OpenSNP challenge will continue accepting submissions starting tomorrow (30th September)

@scarroll32
Copy link
Contributor Author

Have implemented this assuming post challenges are also limited by the same number of submissions. If this is not required for a specific challenge, then the limit can be removed after the end of the challenge (by setting it to zero).

@scarroll32
Copy link
Contributor Author

Incorporated into #327

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants