Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: download sources with double asterisk #538

Merged

Conversation

yzerk
Copy link
Contributor

@yzerk yzerk commented Mar 1, 2023

No description provided.

@yzerk yzerk requested a review from andrii-bodnar March 1, 2023 22:53
@codecov
Copy link

codecov bot commented Mar 3, 2023

Codecov Report

Merging #538 (cd69299) into cli3 (daec97a) will increase coverage by 1.04%.
The diff coverage is 83.34%.

@@             Coverage Diff              @@
##               cli3     #538      +/-   ##
============================================
+ Coverage     60.33%   61.37%   +1.04%     
- Complexity     1095     1112      +17     
============================================
  Files           162      162              
  Lines          4887     4902      +15     
  Branches        751      752       +1     
============================================
+ Hits           2948     3008      +60     
+ Misses         1534     1481      -53     
- Partials        405      413       +8     
Impacted Files Coverage Δ
...in/cli/commands/actions/DownloadSourcesAction.java 49.07% <0.00%> (ø)
.../cli/commands/functionality/TranslationsUtils.java 79.32% <100.00%> (ø)
...in/java/com/crowdin/cli/utils/PlaceholderUtil.java 80.00% <100.00%> (-0.85%) ⬇️

... and 7 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

yzerk and others added 2 commits March 3, 2023 21:38
Co-authored-by: Andrii Bodnar <29282228+andrii-bodnar@users.noreply.github.com>
…onsUtils.java

Co-authored-by: Andrii Bodnar <29282228+andrii-bodnar@users.noreply.github.com>
@andrii-bodnar andrii-bodnar changed the title #315 - download sources with double asterisk fix: download sources with double asterisk Mar 16, 2023
@andrii-bodnar andrii-bodnar merged commit 88ae567 into cli3 Mar 30, 2023
@andrii-bodnar andrii-bodnar deleted the feature/#315-download-sources-with-double-asterisk branch March 30, 2023 12:34
yzerk added a commit that referenced this pull request Apr 11, 2023
yzerk added a commit that referenced this pull request Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

download sources doesn't handle configuration files with ** wildcards in source when dest is configured
2 participants