Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix balance comparison issues when detecting when reimbursement is complete #102

Open
mjmaurer opened this issue Jun 22, 2020 · 2 comments
Open

Fix balance comparison issues when detecting when reimbursement is complete #102

mjmaurer opened this issue Jun 22, 2020 · 2 comments

Comments

@mjmaurer
Copy link
Contributor

https://crownheightsmutualaid.slack.com/archives/C011D4YBWHL/p1592853085112900?thread_ts=1592853085.112900&cid=C011D4YBWHL
@sandfort
Copy link
Collaborator

sandfort commented Jul 3, 2020 •
edited
Loading

It looks like we're already using <= for this:

mutual-aid-app/src/slackapp/event-listeners/reimbursementReply.js

Line 58 in 9385eaa

newBalance <= 0

Might it be a floating point issue?

@mjmaurer
Copy link
Contributor Author

mjmaurer commented Jul 5, 2020

Yup! You're probably correct.

@mjmaurer mjmaurer changed the title <= instead of < for detecting reimbursement complete Fix balance comparison issues when detecting when reimbursement is complete Jul 5, 2020
@sandfort sandfort self-assigned this Jul 21, 2020
@sandfort sandfort mentioned this issue Jul 24, 2020
Merged
@sandfort sandfort removed their assignment Oct 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sandfort @mjmaurer