Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save volunteer phone number to localStorage/sessionStorage #156

Open
piratefsh opened this issue Oct 8, 2020 · 5 comments
Open

Save volunteer phone number to localStorage/sessionStorage #156

piratefsh opened this issue Oct 8, 2020 · 5 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers sms pickup

Comments

@piratefsh
Copy link
Collaborator

piratefsh commented Oct 8, 2020

Summary

On the user flow for delivery volunteers to pick up deliveries, they have to enter their phone number for each request. Since this can be repetitive, it would be nice to save this phone number in the browser and have it autopopulated in the form.

Requirements:

  • We will also need a way to clear this saved number.
  • Number should only be stored if it has been successfully submitted once
    • Do not store number if it is malformed/not valid

Where

View: /delivery-needed?sms_pickup=true

  • Click on Claim Delivery
  • Click on "Yes I accept" button
  • This is the phone field form: Screen Shot 2020-10-08 at 6 08 37 PM

Considerations

  • Which makes more sense to use, localStorage or sessionStorage?
  • Should we have some text explaining that this is only stored on their browser?

Proposed design

Doesn't have to be exact to this rough mock, best to use MaterialUI components (maybe a secondary button?)
Screen Shot 2020-10-08 at 6 13 34 PM

@piratefsh piratefsh added enhancement New feature or request good first issue Good for newcomers sms pickup labels Oct 8, 2020
@somstrom
Copy link

somstrom commented Oct 9, 2020

@piratefsh

Could you please assign this to me ?

@piratefsh
Copy link
Collaborator Author

hi @somstrom are you added to the CHMA Slack? if yes, please complete 'Before you start' https://github.com/crownheightsaid/mutual-aid-app/blob/master/DEVELOPING.md#Before-you-start so we can give you permission to pick up issues! if not, you can join the Slack by signing up to be a volunteer and completing an orientation session: https://crownheightsmutualaid.com/volunteer/

@ifearcompilererrors ifearcompilererrors self-assigned this Oct 9, 2020
@piratefsh
Copy link
Collaborator Author

@somstrom another contributor has offered to work on this ticket, but we have many other good first issues ( good first issue Good for newcomers ) to pick up when you are ready!

@piratefsh
Copy link
Collaborator Author

hi @ifearcompilererrors how are things going with this ticket? i think the approach of setting the input type you mentioned on Slack will work great for this!

@ifearcompilererrors
Copy link
Collaborator

hi @ifearcompilererrors how are things going with this ticket? i think the approach of setting the input type you mentioned on Slack will work great for this!

hello! thanks for pinging- aiming to get the PR up by wednesday 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers sms pickup
Projects
None yet
Development

No branches or pull requests

3 participants