Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHMA site: Update design on Recurring Donation page #164

Open
sea-witch opened this issue Oct 23, 2020 · 3 comments
Open

CHMA site: Update design on Recurring Donation page #164

sea-witch opened this issue Oct 23, 2020 · 3 comments
Assignees

Comments

@sea-witch
Copy link
Collaborator

sea-witch commented Oct 23, 2020

Update the "Recurring Donation" page with this design:

Donations

The site is in WordPress. The code is not under version control. You just need to open the admin panel and fiddle with it, old-school.

Markup

We have a draft of the new Donation page here. It includes the illustration and some examples of the buttons.

The "buttons" are not buttons at all, but links. Each button should point to the associated PayPal page according to the donation amount. Something like this should work:

<a class="donation-button" href="https://www.paypal.com/cgi-bin/webscr?cmd=_s-xclick&amp;hosted_button_id=3ZHWPFJSD63V6">$10</a>

Gotchas: The html produced by WP is pretty messy. The layout engine seems to produce lots of extra divs and spans. I think the hardest part will be figuring out how to get things lined up nicely without running afoul of the WP editor.

Styles

To get to the site styles...

Open the admin sidebar and select "Customize":
wp-admin-sidebar

Select "Additional CSS":
wp-customizing

Have at it!
wp-additional-css

Code style notes

We should probably be careful of scoping our styles to the donation page, or at least to the elements related to the donation page. This could be as simple as choosing unique class names. This code snippet gets us much of the way there on the buttons:

.donation-button {
	background: #F7CF56;
	color: #47133D;
	text-decoration: none !important;
	padding: 10px 20px;
	border-radius: 20px;
}
@caroqliu
Copy link
Collaborator

I'm not sure how to get access of the WP but I'd be interested in taking this on!

@sea-witch
Copy link
Collaborator Author

@caroqliu That'd be great! I'll follow up on Slack :)

@caroqliu
Copy link
Collaborator

caroqliu commented Mar 26, 2021

Took a stab at editing the page following the mock, PTAL and review @saoirse-zee :)

A few decisions I made:

  • Not sure the exact dimensions of the buttons desired, but I used a CSS flex box to space 5 buttons evenly in each row - this manifests as each one taking up 16% of width and 4% of margin between them up to a container of 580px. Any wider and the buttons themselves get kind of wide and funny looking, but this was somewhat an arbitrary threshold and can be modified if something else is preferred.
  • Same thing with font sizes, kind of just guessed based on looking at the mock, LMK if these should change. The large size is 28 and the smaller is 14.
  • Recommended a couple edits to the bottom copy, mainly to remove 'but's and 'also's, as well as to link to the ioby page where mentioned. Copied here for reference, but feel free to change it back to the original:

    For now, we can only use PayPal for recurring donations. We are working on a fix to accept credit/debit cards directly. Please note that these recurring donations may not be tax deductible like ones made directly through our ioby page; if you have questions about this please consult a tax accountant.

  • Added alt text to the icon, LMK if there's a better way to describe:

    Graphic showing laptop with multiracial fists raised on the screen

  • Finally, I couldn't find a better way to change the background color on the page other than to do it by class on the Additional CSS page. Because the CSS isn't applied to the page during editing, the text is invisible (white on white background) in edit mode, but in preview mode it should look as expected (white on purple background). Just something to be aware of when editing that the page is in fact not broken. But open to other strategies for styling background that don't have this funny side effect. :)

Question: Between the mock and the current page, it looks like we lose the option to recurring donate $80. Is that intended?

@caroqliu caroqliu self-assigned this Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants