Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request] Credential test endpoint #1431

Closed
tthvo opened this issue Mar 27, 2023 · 0 comments · Fixed by #1432
Closed

[Request] Credential test endpoint #1431

tthvo opened this issue Mar 27, 2023 · 0 comments · Fixed by #1432
Assignees
Labels
feat New feature or request high-priority needs-triage Needs thorough attention from code reviewers

Comments

@tthvo
Copy link
Member

tthvo commented Mar 27, 2023

Describe the feature

Why don't we just have a connection checking endpoint that specifically does not load any stored credentials? It either uses only the session credentials header for the test, or it ignores the session credentials header and requires the credentials to test to be passed as part of the request body. We can use this endpoint and pass no credentials at first, and just try to open a JMX connection to read some basic MBean data. If that succeeds then we know the target did not require auth. Then the user can supply credentials and we can repeat the test using those.

Originally posted by @andrewazores in cryostatio/cryostat-web#920 (comment)

Any other information?

This is useful for the credential test table.

@tthvo tthvo added feat New feature or request needs-triage Needs thorough attention from code reviewers labels Mar 27, 2023
@tthvo tthvo moved this to Todo in 2.3.0 release Mar 27, 2023
@maxcao13 maxcao13 assigned maxcao13 and unassigned maxcao13 Mar 27, 2023
@github-project-automation github-project-automation bot moved this from Todo to Done in 2.3.0 release Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or request high-priority needs-triage Needs thorough attention from code reviewers
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants