-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] Missing log output since #1720 #1742
Comments
Confirmed, if I back out that change and test it locally then the missing log messages come back. |
Setting the diff --git a/pom.xml b/pom.xml
index 7c55fb83..2e8e4a75 100644
--- a/pom.xml
+++ b/pom.xml
@@ -134,13 +134,6 @@
<type>pom</type>
<scope>import</scope>
</dependency>
- <dependency>
- <groupId>io.vertx</groupId>
- <artifactId>vertx-dependencies</artifactId>
- <version>${io.vertx.version}</version>
- <type>pom</type>
- <scope>import</scope>
- </dependency>
</dependencies>
</dependencyManagement>
@@ -198,14 +191,17 @@
<dependency>
<groupId>io.vertx</groupId>
<artifactId>vertx-web</artifactId>
+ <version>4.4.4</version>
</dependency>
<dependency>
<groupId>io.vertx</groupId>
<artifactId>vertx-web-client</artifactId>
+ <version>4.4.4</version>
</dependency>
<dependency>
<groupId>io.vertx</groupId>
<artifactId>vertx-web-graphql</artifactId>
+ <version>4.4.4</version>
</dependency>
<dependency>
<groupId>com.graphql-java</groupId>
Diff of that output: 33c33
< [INFO] | | | \- com.fasterxml.jackson.core:jackson-annotations:jar:2.15.0:compile
---
> [INFO] | | | \- com.fasterxml.jackson.core:jackson-annotations:jar:2.15.2:compile
74c74
< [INFO] | | +- com.fasterxml.jackson.dataformat:jackson-dataformat-yaml:jar:2.15.0:compile
---
> [INFO] | | +- com.fasterxml.jackson.dataformat:jackson-dataformat-yaml:jar:2.15.2:compile
76,78c76,78
< [INFO] | | +- com.fasterxml.jackson.datatype:jackson-datatype-jsr310:jar:2.15.0:compile
< [INFO] | | +- com.fasterxml.jackson.core:jackson-databind:jar:2.15.0:compile
< [INFO] | | \- com.fasterxml.jackson.core:jackson-core:jar:2.15.0:compile
---
> [INFO] | | +- com.fasterxml.jackson.datatype:jackson-datatype-jsr310:jar:2.15.2:compile
> [INFO] | | +- com.fasterxml.jackson.core:jackson-databind:jar:2.15.2:compile
> [INFO] | | \- com.fasterxml.jackson.core:jackson-core:jar:2.15.2:compile
122,123c122,123
< [INFO] +- org.slf4j:slf4j-jdk14:jar:1.7.36:test
< [INFO] | \- org.slf4j:slf4j-api:jar:1.7.21:compile
---
> [INFO] +- org.slf4j:slf4j-jdk14:jar:1.7.36:compile
> [INFO] | \- org.slf4j:slf4j-api:jar:1.7.36:compile
185c185
< [INFO] Finished at: 2023-10-24T15:34:08-04:00
---
> [INFO] Finished at: 2023-10-24T15:34:15-04:00 |
This looks like it solves it: diff --git a/pom.xml b/pom.xml
index 7c55fb83..969df771 100644
--- a/pom.xml
+++ b/pom.xml
@@ -140,6 +140,16 @@
<version>${io.vertx.version}</version>
<type>pom</type>
<scope>import</scope>
+ <exclusions>
+ <exclusion>
+ <groupId>org.slf4j</groupId>
+ <artifactId>slf4j-api</artifactId>
+ </exclusion>
+ <exclusion>
+ <groupId>org.slf4j</groupId>
+ <artifactId>slf4j-jdk14</artifactId>
+ </exclusion>
+ </exclusions>
</dependency>
</dependencies>
</dependencyManagement>
@@ -232,10 +242,17 @@
<artifactId>jasypt-hibernate5</artifactId>
<version>${org.jasypt-hibernate5.version}</version>
</dependency>
+ <dependency>
+ <groupId>org.slf4j</groupId>
+ <artifactId>slf4j-api</artifactId>
+ <version>${org.slf4j.version}</version>
+ <scope>compile</scope>
+ </dependency>
<dependency>
<groupId>org.slf4j</groupId>
<artifactId>slf4j-jdk14</artifactId>
<version>${org.slf4j.version}</version>
+ <scope>runtime</scope>
</dependency>
<dependency>
<groupId>com.google.code.gson</groupId> |
#1720 somehow breaks some of our logging.
Originally posted by @andrewazores in https://github.com/cryostatio/cryostat/issues/1689#issuecomment-1777884223
The text was updated successfully, but these errors were encountered: