Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manual selection of deployment platform results in PlatformClient not started #344

Closed
andrewazores opened this issue Nov 25, 2020 · 0 comments · Fixed by #345
Closed

Manual selection of deployment platform results in PlatformClient not started #344

andrewazores opened this issue Nov 25, 2020 · 0 comments · Fixed by #345
Assignees
@andrewazores
Labels
bug Something isn't working

Comments

@andrewazores
Copy link
Member

When allowing ContainerJFR to detect the runtime platform automatically, the PlatformClient implementation is start()ed once by the PlatformModule. However, if the platform is specified manually with the env var CONTAINER_JFR_PLATFORM, then the client is never started. This currently leads to broken async target discovery, since that is the only behaviour enabled when starting the platform clients.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrewazores andrewazores

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Do not exit early from platform detection andrewazores/cryostat
1 participant
@andrewazores