You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When POSTing a rule definition, all of the same validations should be performed on the input whether it is supplied as a form or a a JSON document. Currently, the JSON document pathway does not validate numeric inputs the same way that the form pathway does.
The text was updated successfully, but these errors were encountered:
There needs to be a way for users to specify unlimited size/age, so this could be 0 or a negative value. If the max age isn't specified but the archival period is specified then the max age is set to equal the archival period, so that the series of archived recordings contain as little overlapping data as possible.
Gson would normally deserialize a missing numeric entry as 0 here anyway, so a negative value would mean the client explicitly specified no limit - but they could just as easily use 0 to do this, if that's what the API spec defines. So I think requiring non-negative is okay here.
cryostatio/cryostat#416 (comment)
When POSTing a rule definition, all of the same validations should be performed on the input whether it is supplied as a form or a a JSON document. Currently, the JSON document pathway does not validate numeric inputs the same way that the form pathway does.
The text was updated successfully, but these errors were encountered: