Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP timeout handler should not apply to all API requests #736

Closed
andrewazores opened this issue Oct 26, 2021 · 0 comments · Fixed by #737
Closed

HTTP timeout handler should not apply to all API requests #736

andrewazores opened this issue Oct 26, 2021 · 0 comments · Fixed by #737
Assignees
Labels
bug Something isn't working

Comments

@andrewazores
Copy link
Member

Originally the timeout handler was added as a way to prevent indefinite hanging when clients requested non-API paths from the webserver, such as web-client asset paths, which did not exist (ex. from a minimal build image). We have better solutions now that result in a proper 404 response in this scenario anyway. If the timeout handler remains in place then it should at least not apply to actual API requests, which may be reasonably expected in many cases to take longer than the default timeout handler time (ex. uploading recording to archives, uploading recording to jfr-datasource, downloading recording from Cryostat).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant