Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Operator SDK to at least 1.8.2 #287

Closed
ebaron opened this issue Nov 1, 2021 · 3 comments · Fixed by #430
Closed

Upgrade Operator SDK to at least 1.8.2 #287

ebaron opened this issue Nov 1, 2021 · 3 comments · Fixed by #430
Assignees
Labels
bug Something isn't working build

Comments

@ebaron
Copy link
Member

ebaron commented Nov 1, 2021

The operator's service account should not be included in the bundle. It should instead be created and managed by OLM. Having this service account present in the bundle results in the following scorecard failure:
Error: Value cryostat-operator-service-account: invalid service account found in bundle. sa name cannot match service account defined for deployment spec in CSV

Operator SDK excludes the operator's service account when generating bundles with this fix: operator-framework/operator-sdk#5120. This fix is present in 1.8.2, 1.9.2, 1.10.1, 1.11.0+. We should upgrade to one of these versions.

@ebaron ebaron added bug Something isn't working build labels Nov 1, 2021
@ebaron
Copy link
Member Author

ebaron commented Nov 1, 2021

We are currently using Operator SDK 1.5.0. The migration guide outlines steps to be taken when upgrading: https://sdk.operatorframework.io/docs/upgrading-sdk-version/

@tthvo
Copy link
Member

tthvo commented Jul 19, 2022

Hi @ebaron I am wondering which release version we are aiming to upgrade to?

From the test suite of the operator-community repo, they are using v1.16.0. Would v1.16.0 be our target?

https://github.com/redhat-openshift-ecosystem/operator-test-playbooks/blob/992cb71004646184da86688a48466e7de84dba4b/roles/install_operator_prereqs/defaults/main.yml#L3

@ebaron
Copy link
Member Author

ebaron commented Jul 19, 2022

I would say target the newest release, unless some major incompatibility is mentioned in the migration docs between 1.16 and the newest.

@tthvo tthvo moved this to Todo in 2.2.0 Release Jul 20, 2022
@tthvo tthvo moved this from Todo to In Progress in 2.2.0 Release Jul 28, 2022
Repository owner moved this from In Progress to Done in 2.2.0 Release Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working build
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants