FlightRecorder/Recording API broken after upgrading from 2.0

[ebaron]

Since existing services are not updated yet by the operator (see #294), the Cryostat service created by 2.0 will still have the name export for its HTTP port instead of the newer name http. This results in the operator not being able to find the HTTP port as seen below:

ERROR controller-runtime.manager.controller.flightrecorder Reconciler error {"reconciler group": "operator.cryostat.io", "reconciler kind": "FlightRecorder", "name": "cryostat-sample-64cf97c97f-qnsb9", "namespace": "cryostat-test", "error": "Cryostat service had no port named \"http\""}
github.com/go-logr/zapr.(*zapLogger).Error
/remote-source/deps/gomod/pkg/mod/github.com/go-logr/zapr@v0.2.0/zapr.go:132
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler
/remote-source/deps/gomod/pkg/mod/sigs.k8s.io/controller-runtime@v0.7.2/pkg/internal/controller/controller.go:267
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem
/remote-source/deps/gomod/pkg/mod/sigs.k8s.io/controller-runtime@v0.7.2/pkg/internal/controller/controller.go:235
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func1.1
/remote-source/deps/gomod/pkg/mod/sigs.k8s.io/controller-runtime@v0.7.2/pkg/internal/controller/controller.go:198
k8s.io/apimachinery/pkg/util/wait.JitterUntilWithContext.func1
/remote-source/deps/gomod/pkg/mod/k8s.io/apimachinery@v0.19.2/pkg/util/wait/wait.go:185
k8s.io/apimachinery/pkg/util/wait.BackoffUntil.func1
/remote-source/deps/gomod/pkg/mod/k8s.io/apimachinery@v0.19.2/pkg/util/wait/wait.go:155
k8s.io/apimachinery/pkg/util/wait.BackoffUntil
/remote-source/deps/gomod/pkg/mod/k8s.io/apimachinery@v0.19.2/pkg/util/wait/wait.go:156
k8s.io/apimachinery/pkg/util/wait.JitterUntil
/remote-source/deps/gomod/pkg/mod/k8s.io/apimachinery@v0.19.2/pkg/util/wait/wait.go:133
k8s.io/apimachinery/pkg/util/wait.JitterUntilWithContext
/remote-source/deps/gomod/pkg/mod/k8s.io/apimachinery@v0.19.2/pkg/util/wait/wait.go:185
k8s.io/apimachinery/pkg/util/wait.UntilWithContext
/remote-source/deps/gomod/pkg/mod/k8s.io/apimachinery@v0.19.2/pkg/util/wait/wait.go:99

A simple workaround for this fix is to delete existing services and the deployment, so the operator can recreate them:

cryostats=$(kubectl get cryostat --template '{{range .items}}{{.metadata.name}}{{"\n"}}{{end}}')
for cryostat in ${cryostats}; do
  kubectl delete svc,deploy -lapp="${cryostat}"
done

Bear in mind that the FlightRecorder and Recording APIs are now deprecated (#349) and will be removed in a future version.