Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Label/Annotation filtering for target nodes is broken #1311

Closed
tthvo opened this issue Jul 30, 2024 · 6 comments · Fixed by #1312
Closed

[Bug] Label/Annotation filtering for target nodes is broken #1311

tthvo opened this issue Jul 30, 2024 · 6 comments · Fixed by #1312
Assignees
Labels
bug Something isn't working

Comments

@tthvo
Copy link
Member

tthvo commented Jul 30, 2024

Current Behavior

The label/annotation filtering for target nodes is broken as it is now showed as below:

image

Expected Behavior

The labels show as key=value.

Steps To Reproduce

  1. bash smoketesh.bash on latest main.
  2. Open https://localhost:8443
  3. Go to Topology View
  4. Select filter by Target Label or Annotation.
  5. Click on the search input to show available options.
  6. The [object Object] is displayed.

Environment

- OS: Fedora 40
- Environment: `docker-compose` with smoketest
- Version: Cryostat 4.0.0-dev

Anything else?

Potentially affected 3.0.0 release.

@tthvo tthvo added the bug Something isn't working label Jul 30, 2024
@tthvo tthvo moved this to Backlog in 3.0.1 release Jul 30, 2024
@tthvo tthvo moved this to Backlog in 4.0.0 release Jul 30, 2024
@tthvo
Copy link
Member Author

tthvo commented Jul 30, 2024

Looks like some regressions when labels/annotations change their representations to [{key: "my-key", value: "my-value"}] list.

@andrewazores
Copy link
Member

Confirmed that this is present in 3.0.0.

@andrewazores
Copy link
Member

I also never realized before, but we render recording labels like template: Profiling, but Topology node labels/annotations like version=1.20. I'll clean that up with the same PR.

@andrewazores
Copy link
Member

Actually, I'll split that change out, since we should backport the bug fix only.

@tthvo
Copy link
Member Author

tthvo commented Jul 30, 2024

I also never realized before, but we render recording labels like template: Profiling, but Topology node labels/annotations like version=1.20. I'll clean that up with the same PR.

Ah yes, about this tho, the topology is following key=value convention on the OpenShift side. Should we follow that instead of key: value?

@andrewazores
Copy link
Member

That's true. I'll adjust the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants