Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recordings row expansion for Reports view is kept between targets #263

Closed
andrewazores opened this issue Aug 30, 2021 · 0 comments · Fixed by #272
Closed

Recordings row expansion for Reports view is kept between targets #263

andrewazores opened this issue Aug 30, 2021 · 0 comments · Fixed by #272
Assignees
Labels
bug Something isn't working

Comments

@andrewazores
Copy link
Member

To reproduce:

  • Run sh smoketest.sh on latest main
  • Select the 9093 demo application
  • Create a recording with any settings
  • Select the quarkus-run.jar demo application
  • Create another recording with any settings
  • Expand the Active Recordings list row item for the recording to view the automated report
  • Re-select the 9093 demo application

(This works with any pair or larger group of targets, and also works with larger numbers of active or archived recordings)

Current behaviour:
When switching from target A to target B with recording R1 expanded to view the report, the list updates with the recordings for target B, and recording row item R2 expanded to view its report.

Expected behaviour:
Switching from target A with R1 expanded to target B should result in the target list being fully collapsed - the table state should not mirror what it previously was for a different target.

Bonus:
Switching from B back to A could restore the expanded R1 state. This is a nice-to-have - I think it would be sufficient to switch back and simply have the whole table fully collapsed again.

Reasoning:
Report generation is an expensive operation, which is why we hide the reports by default and only generate and display them to the user when specifically requested. The current behaviour seems like a bug, because the user may be interested in seeing the report for R1 in target A, but not interested in seeing the report for R2 when switching to target B. In many scenarios, the report for R2 will not have been previously cached because the recording is still active and running, so the resource consumption of the operation should be avoided until again explicitly requested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants