Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification Categories #268

Closed
andrewazores opened this issue Aug 31, 2021 · 2 comments · Fixed by #283
Closed

Notification Categories #268

andrewazores opened this issue Aug 31, 2021 · 2 comments · Fixed by #283
Assignees
Labels
feat New feature or request

Comments

@andrewazores
Copy link
Member

Since #245 / #255, notifications go into a drawer with the most recent entry at the top, organized purely chronologically. It might be more useful for users if notifications were grouped by either notification category (as in WebSocket notifications channel "category" key), or by graphical notification level, and sorted chronologically within those categories.

@andrewazores andrewazores added the feat New feature or request label Aug 31, 2021
@jan-law jan-law self-assigned this Sep 9, 2021
@jan-law
Copy link
Contributor

jan-law commented Sep 10, 2021

If you look at my rough demo screenshots, I wanted to separate the notifications that confirm user actions from the notifications that show target info. The warnings/errors have their own category to make it easier for users to find the error again after they close the toast notification. What do you think of the notification category grouping and header titles?

Also, if there are many “Completed Actions”, the “Network Info” and “Problems” headers aren’t visible until you scroll down, which could be confusing if users see an error toast notification and don’t know where the notification went.
Patternfly guidelines suggest no more than 3-4 categories and that only one category is expanded at a time. To fix the problem, I was thinking of automatically expanding the “Problems” category if there’s at least one unread error. What do you think?

image
image
image
image

@andrewazores
Copy link
Member Author

I was thinking of automatically expanding the “Problems” category if there’s at least one unread error. What do you think?

That sounds like a really good idea to me. Looks excellent so far.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants