Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve "Take me home" button styling #295

Closed
jan-law opened this issue Sep 24, 2021 · 7 comments · Fixed by #324
Closed

Improve "Take me home" button styling #295

jan-law opened this issue Sep 24, 2021 · 7 comments · Fixed by #324
Assignees
Labels
good first issue Good for newcomers

Comments

@jan-law
Copy link
Contributor

jan-law commented Sep 24, 2021

The "Take me home" button on the 404 page looks like regular text. Perhaps it could be improved to closer resemble a clickable link:
image

@PuneetDabral
Copy link

sir can i ...but i need your support for this i am new in open source ....

@aptmac
Copy link
Member

aptmac commented Sep 24, 2021

The PatternFly design documentation outlines what a 404 page could look like, https://www.patternfly.org/v4/ux-writing/http-404-pages/

This can be achieved with the PF empty-state component (https://www.patternfly.org/v4/components/empty-state#examples), which is what the PatternFly 404 page is made from if you inspect the html at: https://www.patternfly.org/v4/404/

@PuneetDabral
Copy link

i can try it assign it to me ..!!

@PuneetDabral
Copy link

help me to resolve this sir

@jan-law
Copy link
Contributor Author

jan-law commented Sep 27, 2021

How can we help? Could you describe to us in more detail what questions or problems you are facing as well as what you have already tried?

@PuneetDabral
Copy link

sir basically first when i use yarn install it gives the error ....

@andrewazores
Copy link
Member

sir basically first when i use yarn install it gives the error ....

More details, please. What error do you see?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants