Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task] Add metadata/labels editor on archived recording upload form #510

Closed
andrewazores opened this issue Sep 15, 2022 · 1 comment · Fixed by #532
Closed

[Task] Add metadata/labels editor on archived recording upload form #510

andrewazores opened this issue Sep 15, 2022 · 1 comment · Fixed by #532
Assignees
Labels
feat New feature or request

Comments

@andrewazores
Copy link
Member

https://github.com/cryostatio/cryostat/pull/1063

The backend is able to accept labels attributes on the POST form for uploading recordings. We should add the label editor component to the upload dialog so that users may choose to add labels to their uploads right away, instead of needing to do the upload and then add labels later, which may be a long time later if it is a large upload.

@andrewazores andrewazores added the feat New feature or request label Sep 15, 2022
@andrewazores
Copy link
Member Author

Since #505 is also merged, I wonder if it makes sense for users to be able to re-upload the recording.metadata.json file to provide the labels. The UI could get messy so it's just a thought. I imagine an upload button within the label editor that summons a JSON file dialog. After the user selects a metadata JSON file and submits it, the frontend parses the file and looks for the .metadata.labels map structure within. Whatever it finds is both added to the form submission for the recording upload, as well as rendered as label cells.

@andrewazores andrewazores moved this to Todo in 2.2.0 Release Sep 20, 2022
@andrewazores andrewazores moved this from Todo to Stretch Goals in 2.2.0 Release Sep 20, 2022
@tthvo tthvo self-assigned this Sep 27, 2022
Repository owner moved this from Stretch Goals to Done in 2.2.0 Release Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or request
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants