Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task] Updates with notifications should account for current error #605

Open
tthvo opened this issue Nov 1, 2022 · 1 comment
Open

[Task] Updates with notifications should account for current error #605

tthvo opened this issue Nov 1, 2022 · 1 comment
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@tthvo
Copy link
Member

tthvo commented Nov 1, 2022

Right now, if their is an error view, notifications will continue to update the table without considering the current error.

For example:

  1. Have 2 tabs open for Cryostat web console. Both use Browser Session settings for credentials.
  2. Connect to a target that requires credentials on both tab.
  3. Enter credentials on one tab and close the modal on the other (display error view).
  4. Create a new recording on the tab with valid credentials.
  5. Tab with error view does not update but receives notification. However, if you click on toolbar filter, you can see data (i.e. name, labels, ...) of the new recording.

Screenshot from 2022-11-01 17-46-27

@tthvo
Copy link
Member Author

tthvo commented Nov 1, 2022

I guess the question is should these notifications pop up at all when error view is shown?

@tthvo tthvo added the question Further information is requested label Nov 1, 2022
@tthvo tthvo moved this to Todo in 2.3.0 release Nov 3, 2022
@andrewazores andrewazores moved this from Todo to Pushed to 2.4.0 in 2.3.0 release Apr 6, 2023
@tthvo tthvo added good first issue Good for newcomers and removed question Further information is requested labels May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
No open projects
Status: Pushed to 2.4.0
Development

No branches or pull requests

1 participant