Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task] Notifcation context provider is not defined #610

Closed
tthvo opened this issue Nov 5, 2022 · 0 comments · Fixed by #676
Closed

[Task] Notifcation context provider is not defined #610

tthvo opened this issue Nov 5, 2022 · 0 comments · Fixed by #676
Assignees
Labels
chore Refactor, rename, cleanup, etc. good first issue Good for newcomers

Comments

@tthvo
Copy link
Member

tthvo commented Nov 5, 2022

Right now, calls to React.useContext(NotificationsContext) will return the default NotificationsInstance because there is no provider in the top of the tree as ServiceContext as below:

<ServiceContext.Provider value={defaultServices}>
    <Provider store={store}>
      <Router>
        <AppLayout>
          <AppRoutes />
        </AppLayout>
      </Router>
    </Provider>
  </ServiceContext.Provider>

I think this is a not an issue that breaks UI but more of a clean up so that the calls are easier to trace.

@tthvo tthvo added the chore Refactor, rename, cleanup, etc. label Nov 5, 2022
@tthvo tthvo moved this to Todo in 2.3.0 release Nov 5, 2022
@tthvo tthvo added the good first issue Good for newcomers label Nov 7, 2022
@tthvo tthvo self-assigned this Nov 18, 2022
Repository owner moved this from Todo to Done in 2.3.0 release Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Refactor, rename, cleanup, etc. good first issue Good for newcomers
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant