Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: bank keeper isn't correctly initialized #411

Merged
merged 1 commit into from
Mar 11, 2021

Conversation

tomtau
Copy link
Contributor

@tomtau tomtau commented Mar 11, 2021

Solution: updated the constructor
as per cosmos/cosmos-sdk@3de3752

@codecov
Copy link

codecov bot commented Mar 11, 2021

Codecov Report

Merging #411 (48132d2) into master (2d553f8) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #411      +/-   ##
==========================================
- Coverage   12.29%   12.25%   -0.05%     
==========================================
  Files          32       32              
  Lines        4903     4903              
==========================================
- Hits          603      601       -2     
- Misses       4031     4034       +3     
+ Partials      269      268       -1     
Flag Coverage Δ
integration_tests 12.51% <ø> (-0.04%) ⬇️
unit_tests 1.61% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
app/app.go 0.81% <0.00%> (-1.63%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d553f8...48132d2. Read the comment docs.

Copy link
Collaborator

@yihuang yihuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the issue is distrtypes.ModuleName was in the whitelist before, but now all module accounts are disallowed?

@tomtau tomtau merged commit 7c7d78f into crypto-org-chain:master Mar 11, 2021
tomtau added a commit that referenced this pull request Mar 11, 2021
Problem: bank keeper isn't correctly initialized (#411)

Solution: updated the constructor
as per cosmos/cosmos-sdk@3de3752
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants