log cache errors and fallback to store instead of returning error to prevent consensus failure

Author: randy-cro

x/staking/keeper/delegation.go

@@ -452,9 +452,7 @@ func (k Keeper) GetUBDQueueTimeSlice(ctx context.Context, timestamp time.Time) (
 		if err == nil {
 			return cachedPairs, nil
 		}
-		if !errors.Is(err, types.ErrCacheMaxSizeReached) {
-			return nil, err
-		}
+		k.Logger(ctx).Error("GetUBDQueueTimeSlice from cache failed. Error: %s", err)
 	}
 
 	store := k.storeService.OpenKVStore(ctx)
@@ -574,9 +572,7 @@ func (k Keeper) GetUBDs(ctx context.Context, endTime time.Time) (map[string][]ty
 		if err == nil {
 			return pairs, nil
 		}
-		if !errors.Is(err, types.ErrCacheMaxSizeReached) {
-			return nil, err
-		}
+		k.Logger(ctx).Error("GetUBDs from cache failed. Error: %s", err)
 	}
 	return k.GetUnbondingDelegationsQueueFromStore(ctx, endTime)
 }
@@ -845,9 +841,7 @@ func (k Keeper) GetRedelegationQueueTimeSlice(ctx context.Context, timestamp tim
 		if err == nil {
 			return cachedTriplets, nil
 		}
-		if !errors.Is(err, types.ErrCacheMaxSizeReached) {
-			return nil, err
-		}
+		k.Logger(ctx).Error("GetRedelegationQueueTimeSlice from cache failed. Error: %s", err)
 	}
 
 	store := k.storeService.OpenKVStore(ctx)
@@ -1497,9 +1491,7 @@ func (k Keeper) GetPendingRedelegations(ctx context.Context, currTime time.Time)
 		if err == nil {
 			return redelegations, nil
 		}
-		if !errors.Is(err, types.ErrCacheMaxSizeReached) {
-			return nil, err
-		}
+		k.Logger(ctx).Error("GetPendingRedelegations from cache failed. Error: %s", err)
 	}
 	return k.GetRedelegationsQueueFromStore(ctx, currTime)
 }

x/staking/keeper/validator.go

@@ -452,9 +452,7 @@ func (k Keeper) GetUnbondingValidators(ctx context.Context, endTime time.Time, e
 		if err == nil {
 			return cachedAddrs, nil
 		}
-		if !errors.Is(err, types.ErrCacheMaxSizeReached) {
-			return nil, err
-		}
+		k.Logger(ctx).Error("GetUnbondingValidators from cache failed. Error: %s", err)
 	}
 
 	store := k.storeService.OpenKVStore(ctx)
@@ -674,9 +672,7 @@ func (k Keeper) GetPendingUnbondingValidators(ctx context.Context, endTime time.
 		if err == nil {
 			return addrs, nil
 		}
-		if !errors.Is(err, types.ErrCacheMaxSizeReached) {
-			return nil, err
-		}
+		k.Logger(ctx).Error("GetPendingUnbondingValidators from cache failed. Error: %s", err)
 	}
 	return k.GetUnbondingValidatorsFromStore(ctx, endTime, endHeight)
 }