Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Node crypto AES #6

Merged
merged 3 commits into from
Dec 17, 2014
Merged

Use Node crypto AES #6

merged 3 commits into from
Dec 17, 2014

Conversation

dcousens
Copy link
Contributor

This pull request removes the usage of the aes and instead uses the default node crypto module.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling d1bdf28 on nodeaes into * on master*.

@dcousens dcousens mentioned this pull request Dec 16, 2014
jprichardson added a commit that referenced this pull request Dec 17, 2014
@jprichardson jprichardson merged commit 5986f7e into master Dec 17, 2014
@jprichardson
Copy link
Member

Awesome man! Thanks!

@jprichardson
Copy link
Member

Damn, this doesn't work in the browser because it looks like browserify-aes doesn't support setAutoPadding. See https://github.com/cryptocoinjs/bip38/blob/5986f7e80cde136cb8c612dcab77ff8b43e6cfaa/lib/bip38.js#L61 for reference.

@calvinmetcalf
Copy link

@dcousens dcousens deleted the nodeaes branch January 29, 2015 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants