Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check that create transferred the correct amount #1

Open
dmdque opened this issue Mar 27, 2018 · 0 comments
Open

Check that create transferred the correct amount #1

dmdque opened this issue Mar 27, 2018 · 0 comments

Comments

@dmdque
Copy link
Member

dmdque commented Mar 27, 2018

create doesn't verify that the correct amount of tokens were transferred. This can potentially lead to the creation of a malicious Bskt with a malicious underlying token.

Checking the delta of erc20.balanceOf(address(this)) mitigates this possibility.

However, this imposes extra logic, so it's worth considering the tradeoffs. An alternative solution is to publish a curated list of verified tokens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant