Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(engine) Fix crash with hax_lib::fstar::before in recursive bundles #1179

Closed
wants to merge 3 commits into from
Closed

fix(engine) Fix crash with hax_lib::fstar::before in recursive bundles #1179

wants to merge 3 commits into from

Conversation

maximebuyse
Copy link
Contributor

fixes #1177

The crash was due to a name collision between the item that has the attribute hax_lib::fstar::before and the Quote item created by the TransformHaxLibInline phase. Instead of giving it the exact same name as before, we add a postfix.

@maximebuyse maximebuyse requested a review from W95Psp December 10, 2024 16:04
@W95Psp
Copy link
Collaborator

W95Psp commented Dec 11, 2024

I guess this was making a collision because of two items sharing a same name below an anonymous const, is that what it is?
The problem is not about the quote I think, but more about the bundling mechanism not ensure unique names while moving items.

I think the naming improvements we talked about yesterday will solve those issues.

@maximebuyse
Copy link
Contributor Author

I guess this was making a collision because of two items sharing a same name below an anonymous const, is that what it is? The problem is not about the quote I think, but more about the bundling mechanism not ensure unique names while moving items.

I think the naming improvements we talked about yesterday will solve those issues.

The problem is not only about the new names in the bundle. The collision is a problem with the old names because when we rename we need original names to be unique (otherwise if we have two things with the same name and they get different names in the bundle, when we find an occurrence of the old name and have to rename it, which one of the new names do we choose?).

The naming improvements could help by allowing to define a name for the Quote item that is different from the item it is attached to (and doing so in a nicer way that what is in this PR). But we need to do this at the creation of the Quote item.

@maximebuyse
Copy link
Contributor Author

maximebuyse commented Dec 12, 2024 •
edited
Loading

We should wait for the naming (#1163) to be implemented and use a fresh ident.

@franziskuskiefer
Copy link
Member

@W95Psp let's merge

@W95Psp W95Psp enabled auto-merge January 20, 2025 14:39
@W95Psp W95Psp mentioned this pull request Jan 20, 2025
Open
25 tasks
W95Psp
W95Psp approved these changes Jan 20, 2025
View reviewed changes
Copy link
Collaborator

@W95Psp W95Psp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge and revert when #1199 is in

@franziskuskiefer
Copy link
Member

Fixed elsewhere

auto-merge was automatically disabled January 23, 2025 12:45

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@W95Psp W95Psp W95Psp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crash with hax_lib::fstar::before in recursive bundle
3 participants
@maximebuyse @W95Psp @franziskuskiefer