Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensures/requires on traits and impls: better ergonomics #829

Open
W95Psp opened this issue Aug 7, 2024 · 4 comments
Open

ensures/requires on traits and impls: better ergonomics #829

W95Psp opened this issue Aug 7, 2024 · 4 comments
Labels
enhancement New feature or request lib Lib-related issue (e.g. annotations lib)

Comments

@W95Psp
Copy link
Collaborator

W95Psp commented Aug 7, 2024

We can right ensures and requires on methods in impls and traits, but that requires putting a #[hax_lib::attributes] on the impl or trait block.

That is fine, but when the user forgets to put that #[hax_lib::attributes], we should output a nice error message with hints (the hint being: add hax_lib::attribtue).

@W95Psp W95Psp added enhancement New feature or request lib Lib-related issue (e.g. annotations lib) labels Aug 7, 2024
@karthikbhargavan

This comment has been minimized.

Copy link

github-actions bot commented Oct 8, 2024

This issue has been marked as stale due to a lack of activity for 60 days. If you believe this issue is still relevant, please provide an update or comment to keep it open. Otherwise, it will be closed in 7 days.

@github-actions github-actions bot added the stale label Oct 8, 2024
@W95Psp
Copy link
Collaborator Author

W95Psp commented Oct 14, 2024

Would still be useful

@W95Psp W95Psp removed the stale label Oct 14, 2024
Copy link

This issue has been marked as stale due to a lack of activity for 60 days. If you believe this issue is still relevant, please provide an update or comment to keep it open. Otherwise, it will be closed in 7 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lib Lib-related issue (e.g. annotations lib)
Projects
None yet
Development

No branches or pull requests

2 participants