Autocorrect errors

[veelenga]

The ability to autocorrect sources using a list of found errors. For example, me as a user seeing this error:

def has_user? # PredicateName: Favour method name 'user?' over 'has_user?'
end

would love to be able to automatically convert it to:

def user?
end

Should be doable with Crystal::Transformer. Here is a simple example:

https://github.com/crystal-lang/crystal/blob/master/samples/compiler/transformer_example.cr

[hugoabonizio]

Awesome! But how to handle the cases where problems comes from third-party shards?

[veelenga]

We don't inspect third-party shards. lib/ directory is excluded from the list of sources.

[hugoabonizio]

Actually I was thinking in this case:

if OtherLib.has_something?
  # ...
end

But I didn't realised Ameba only checks for methods definitions, not calls. Sorry!

[veelenga]

Ah, okay that is an interesting point. For this particular rule (PredicateName) that wouldn't be a case, because it is looking for the method definition, not the method call. So it will not report an error and there will be nothing to autocorrect. But there might be other rules which could do other inspections for third-party calls. Will keep this in mind, thank you.

[anicholson]

Oh yes please! I don't want to use a linter that doesn't fix the things it knows how to :)

[kostya]

in my project i have ~500 errors: LargeNumbers: Large numbers should be written with underscores, replace it by hands is pain.

[veelenga]

@kostya @anicholson any help is appreciated :)

Btw, LargeNumbers is now disabled by default in master.

[veelenga]

Closed by

#248