-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MT breaks Lint/Typos
rule
#473
Comments
Any idea why this is happening? I would consider #474 a useful workaround. But it's really odd that this fails. Spawning processes should work in a MT environment just fine. |
@straight-shoota Dunno but it could be a bug on the |
When spawning a external processes, the effect of multi-threading shouldn't be much different from single-threaded concurrency. Even within a single thread, multiple processes and be started concurrently and run in parallel. It might be interesting to observe how many processes run in parallel. |
@straight-shoota each file (source) is being run in a separate fiber, so in approximation there should be as much of 'em as the number of crystal source files in the repo. I remember having this issue in multiple repos, not just this one. |
Oh, that's a lot then. If they all spawn processes concurrently that can lead to a lot of processes running in parallel. Might be worth to consider some throttling, like running only a hand full of worker fibers per thread. |
When ameba is built with
-Dpreview_mt
, theRule::Lint::Typos
rule hangs indefinitely while callingProcess.run
.The text was updated successfully, but these errors were encountered: