Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make linker configurable on Windows #12988

Closed
straight-shoota opened this issue Jan 21, 2023 · 3 comments · Fixed by #13376
Closed

Make linker configurable on Windows #12988

straight-shoota opened this issue Jan 21, 2023 · 3 comments · Fixed by #13376
Labels
kind:feature platform:windows Windows support based on the MSVC toolchain / Win32 API topic:compiler:codegen

Comments

@straight-shoota
Copy link
Member

On POSIX platforms, the linker can be configured via the CC environment variable. This does not work on Windows currently, neither does the equivalent of CL.
It should be possible to configure the linker on Windows as well.
@straight-shoota straight-shoota added kind:feature platform:windows Windows support based on the MSVC toolchain / Win32 API topic:compiler:codegen labels Jan 21, 2023
@straight-shoota straight-shoota changed the title Make linekr configurable on Windows Make linker configurable on Windows Jan 21, 2023
@HertzDevil
Copy link
Contributor

%CL% is reserved by MSVC to pass extra command-line options to the compiler, i.e. it is essentially a different %CFLAGS%. So we should use %CC% even on Windows

@straight-shoota
Copy link
Member Author

Related: #5430 (comment)

@HertzDevil HertzDevil moved this to Todo in Windows Support Mar 15, 2023
@HertzDevil HertzDevil mentioned this issue Apr 21, 2023
Merged
@HertzDevil HertzDevil moved this from Todo to In Progress in Windows Support Apr 21, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Windows Support Apr 26, 2023
@3052
Copy link

3052 commented Jan 14, 2024

OK so how does this work? here is still says visual studio is required:

https://crystal-lang.org/install/on_windows/

but if this issue works as advertised, that should no longer be the case

@3052 3052 mentioned this issue Jan 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind:feature platform:windows Windows support based on the MSVC toolchain / Win32 API topic:compiler:codegen
Projects
Windows Support
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Respect %CC% on Windows HertzDevil/crystal
3 participants
@straight-shoota @HertzDevil @3052