Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change name of printer "pausable" -> "not-pausable" #1670

Closed
devtooligan opened this issue Feb 19, 2023 · 0 comments
Closed

Change name of printer "pausable" -> "not-pausable" #1670

devtooligan opened this issue Feb 19, 2023 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@devtooligan
Copy link
Contributor

Describe the issue:

The results of this printer threw me. It's called "pausable" but it returns all the functions that are not pausable.

Should we have both a "pausable" and "not-pausable"? If not should we update either the logic to reflect the name or else update the arg name?

Code example to reproduce the issue:

https://github.com/crytic/slither/blob/master/slither/printers/summary/when_not_paused.py#L26

class PrinterWhenNotPaused(AbstractPrinter):

    ARGUMENT = "pausable"
    HELP = "Print functions that do not use whenNotPaused"

    WIKI = "https://github.com/trailofbits/slither/wiki/Printer-documentation#when-not-paused"

Version:

0.9.2

Relevant log output:

Constructor and pure/view functions are not displayed

Zero:
+---------------+-------------------+
|      Name     | Use whenNotPaused |
+---------------+-------------------+
| constructor() |                   |
+---------------+-------------------+

One:
+---------------+-------------------+
|      Name     | Use whenNotPaused |
+---------------+-------------------+
| constructor() |                   |
+---------------+-------------------+

Two:
+---------------+-------------------+
|      Name     | Use whenNotPaused |
+---------------+-------------------+
| constructor() |                   |
+---------------+-------------------+

Test:
+----------------+-------------------+
|      Name      | Use whenNotPaused |
+----------------+-------------------+
| constructor()  |                   |
|     test()     |                   |
| test2(uint256) |                   |
| test3(uint256) |                   |
|    test4()     |                   |
+----------------+-------------------+
@devtooligan devtooligan added the bug-candidate Bugs reports that are not yet confirmed label Feb 19, 2023
@devtooligan devtooligan changed the title [Fix]: Change name of printer "pausable" -> "not-pausable" [Bug-candidate]: Change name of printer "pausable" -> "not-pausable" Feb 19, 2023
@devtooligan devtooligan changed the title [Bug-candidate]: Change name of printer "pausable" -> "not-pausable" [Bug-Candidate]: Change name of printer "pausable" -> "not-pausable" Feb 19, 2023
@0xalpharush 0xalpharush changed the title [Bug-Candidate]: Change name of printer "pausable" -> "not-pausable" Change name of printer "pausable" -> "not-pausable" Mar 17, 2023
@0xalpharush 0xalpharush added enhancement New feature or request good first issue Good for newcomers and removed bug-candidate Bugs reports that are not yet confirmed labels Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants