[Bug]: type alias namespace collision causes assertion failure in tmp_call.py

[kevinclancy]

Describe the issue:

When I define I type alias in one contract and define a struct with the same name in the other contract, the type alias is used as the called field of the struct constructor call. This causes an assertion error.

Code example to reproduce the issue:

pragma solidity 0.8.13;

contract OtherTest {
    struct Z {
        int x;
        int y;
    }

    function myfunc() external {
        Z memory z = Z(2,3);
    }
}

contract DeleteTest {
    type Z is int;
}

Version:

0.9.3

Relevant log output:

...
  File "/Users/kevin.clancy/.pyenv/versions/3.9.13/lib/python3.9/site-packages/slither/visitors/slithir/expression_to_slithir.py", line 160, in __init__
    self._visit_expression(self.expression)
  File "/Users/kevin.clancy/.pyenv/versions/3.9.13/lib/python3.9/site-packages/slither/visitors/expression/expression.py", line 46, in _visit_expression
    self._visit_assignement_operation(expression)
  File "/Users/kevin.clancy/.pyenv/versions/3.9.13/lib/python3.9/site-packages/slither/visitors/expression/expression.py", line 102, in _visit_assignement_operation
    self._visit_expression(expression.expression_right)
  File "/Users/kevin.clancy/.pyenv/versions/3.9.13/lib/python3.9/site-packages/slither/visitors/expression/expression.py", line 96, in _visit_expression
    self._post_visit(expression)
  File "/Users/kevin.clancy/.pyenv/versions/3.9.13/lib/python3.9/site-packages/slither/visitors/expression/expression.py", line 276, in _post_visit
    self._post_call_expression(expression)
  File "/Users/kevin.clancy/.pyenv/versions/3.9.13/lib/python3.9/site-packages/slither/visitors/slithir/expression_to_slithir.py", line 366, in _post_call_expression
    message_call = TmpCall(called, len(args), val, expression.type_call)
  File "/Users/kevin.clancy/.pyenv/versions/3.9.13/lib/python3.9/site-packages/slither/slithir/tmp_operations/tmp_call.py", line 29, in __init__
    assert isinstance(
AssertionError

[0xalpharush]

I think the scope may incidentally include DeleteTest.Z despite not being available within OtherTest

slither/slither/core/scope/scope.py

Lines 98 to 99 in 64b2e0c

	if not _dict_contain(new_scope.user_defined_types, self.user_defined_types):
	self.user_defined_types.update(new_scope.user_defined_types)

. This causes an issue when we call find_variable on OtherTest.Z bc it only has Z and matches here

slither/slither/solc_parsing/expressions/find_variable.py

Lines 365 to 366 in 0ec4874

	if var_name in current_scope.user_defined_types:
	return current_scope.user_defined_types[var_name], False