You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Foundation is in place via PR#3 to crytic/solc. Still some work needed in solc-select to utilize the newly added solc binaries.
In the meantime, do we really need to solc-select install all before slither tests? Why not install only the versions that are actually used? No matter how much crytic/solc helps, slither ci will be much faster & stable if it doesn't download solc versions that it doesn't needed.
We frequently have timeout in our CI (ex: https://github.com/crytic/slither/runs/7537262148?check_suite_focus=true) because when solc-select installs everything, it makes a lot of requests to
[binaries.soliditylang](https://binaries.soliditylang.org)
.We could store all the binaries in https://github.com/crytic/solc, and when the user run
install all
crytic/solc
, and copy all the binaries at oncehttps://binaries.soliditylang.org
for the versions that are not there.This will significantly reduce the number of requests and prevent the CI to fail.
We will need to update
crytic/solc
more often, but I think that would be ok.The text was updated successfully, but these errors were encountered: