Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store all binaries in https://github.com/crytic/solc #113

Open
montyly opened this issue Jul 27, 2022 · 2 comments
Open

Store all binaries in https://github.com/crytic/solc #113

montyly opened this issue Jul 27, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@montyly
Copy link
Member

montyly commented Jul 27, 2022

We frequently have timeout in our CI (ex: https://github.com/crytic/slither/runs/7537262148?check_suite_focus=true) because when solc-select installs everything, it makes a lot of requests to [binaries.soliditylang](https://binaries.soliditylang.org).

We could store all the binaries in https://github.com/crytic/solc, and when the user run install all

  • Clone crytic/solc, and copy all the binaries at once
  • And only switch to https://binaries.soliditylang.org for the versions that are not there.

This will significantly reduce the number of requests and prevent the CI to fail.

We will need to update crytic/solc more often, but I think that would be ok.

@bohendo
Copy link

bohendo commented Oct 28, 2022

Foundation is in place via PR#3 to crytic/solc. Still some work needed in solc-select to utilize the newly added solc binaries.

In the meantime, do we really need to solc-select install all before slither tests? Why not install only the versions that are actually used? No matter how much crytic/solc helps, slither ci will be much faster & stable if it doesn't download solc versions that it doesn't needed.

@montyly
Copy link
Member Author

montyly commented Jan 3, 2023

We can switch to individual version for the detectors, but the AST parsing actually use all the versions, so we won't be able to save time there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants