Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed time url bug and increased test coverage #59

Merged
merged 1 commit into from
Mar 8, 2022
Merged

fixed time url bug and increased test coverage #59

merged 1 commit into from
Mar 8, 2022

Conversation

farazmurshed13
Copy link
Collaborator

Time keyword was previously not working in the url when attempting to scrape.

@farazmurshed13 farazmurshed13 added bug Something isn't working story New feature or request labels Mar 8, 2022
@farazmurshed13 farazmurshed13 linked an issue Mar 8, 2022 that may be closed by this pull request
User wants to reserve a specific restaurant at a time #48
Closed
1 task
aayushpatel108
aayushpatel108 approved these changes Mar 8, 2022
View reviewed changes
Copy link
Collaborator

@aayushpatel108 aayushpatel108 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Make sure you add this to the main testing file at some point, or at least some entrypoint where you can run all these tests from another file

@aayushpatel108 aayushpatel108 merged commit 6539dcb into main Mar 8, 2022
@farazmurshed13
Copy link
Collaborator Author

Sounds good - will do

@vsathye vsathye linked an issue Mar 8, 2022 that may be closed by this pull request
URL Navigation #11
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aayushpatel108 aayushpatel108 aayushpatel108 approved these changes

@prithvikannan prithvikannan Awaiting requested review from prithvikannan

@vivekfernz vivekfernz Awaiting requested review from vivekfernz

@vsathye vsathye Awaiting requested review from vsathye

Assignees
No one assigned
Labels
bug Something isn't working story New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

URL Navigation User wants to reserve a specific restaurant at a time
2 participants
@farazmurshed13 @aayushpatel108