Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change archiver to work resource id based #2097

Closed
kulmann opened this issue Sep 23, 2021 · 4 comments · Fixed by #2100
Closed

Change archiver to work resource id based #2097

kulmann opened this issue Sep 23, 2021 · 4 comments · Fixed by #2100
Assignees

Comments

@kulmann
Copy link
Member

kulmann commented Sep 23, 2021

As I've learned in #2096 the archiver service currently works with absolute paths. That brings at least two limitations:

1: we need configuration for the web ui for defining a path prefix. In the CERN-Box environment this is not needed (/), for any standard ownCloud environment it would be /home. This kind of knowledge should not be needed in the web UI (+ this will not work with our spaces implementation)
2: similar to (1) folder downloads will not work for public links

Switching to resource id based file/folder selection for the archive will resolve (1) and (2). Additionally it will allow us to have support folder downloads on password protected public links without extra effort after owncloud/ocis#2536 is merged.

@kulmann
Copy link
Member Author

kulmann commented Sep 23, 2021

cc'ing @wkloucek for more details if needed

@gmgigi96
Copy link
Member

The current archiver implementation has the same interface of an old archiver service, we used, and yes, it is limited.
So, I will change the interface to support both paths and resources ids, providing to the archiver a list of path and/or a list of id.

@kulmann
Copy link
Member Author

kulmann commented Sep 23, 2021

Awesome, thank you 🤩

@butonic
Copy link
Contributor

butonic commented Sep 24, 2021

Related: owncloud/ocis#2521

Cc @kulmann I don't know if @jvillafanez looked into this as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants