Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CERN: Lightweight accounts support #2966

Open
labkode opened this issue Jun 14, 2022 · 14 comments
Open

CERN: Lightweight accounts support #2966

labkode opened this issue Jun 14, 2022 · 14 comments

Comments

@labkode
Copy link
Member

labkode commented Jun 14, 2022

Accounts that they do not have a personal home space but can access (ro/
rw) any shared space (Project Spaces and Shares).

@labkode
Copy link
Member Author

labkode commented Jun 15, 2022

@butonic
Copy link
Contributor

butonic commented Jun 20, 2022

While the lightweight account code has been merged we plan to support guest accounts with roles. Currently, reva calls CreateHome for every user. We should only make the CreateHome call for accounts that should be autoprovisioned. For guests that is not the case. We can identify guests based on their role or the idp.

Anyway, even if the CreateHome call fails (eg because it already exists) the user is allowed to login. So guest / lightweight accounts should be able to login. The /graph/v1.0/me/drives endpoint will not list a personal space for them. The question is if the clients can deal with that. They should hide the UI for the users home space and not expect every user to have a personal space.

@kulmann
Copy link
Member

kulmann commented Jun 20, 2022

What should the initial view of the files app be for web? Shares? At the moment web is not capable of dealing with no personal space being available, because the personal view is the default route of the files app.

@TheOneRing
Copy link
Contributor

I'd expect the desktop client to work as expected.

@felix-schwarz
Copy link

felix-schwarz commented Jun 22, 2022

The iOS client currently sees the personal space as just another space among many, so I'd expect this to just work.

@abelgardep
Copy link

The android client does not support spaces yet

@kulmann
Copy link
Member

kulmann commented Jun 30, 2022

What should the initial view of the files app be for web? Shares? At the moment web is not capable of dealing with no personal space being available, because the personal view is the default route of the files app.

@labkode could you give a statement on this?

@labkode
Copy link
Member Author

labkode commented Jul 1, 2022

@kulmann this is what we give:
Screenshot 2022-07-01 at 09 07 10

@kulmann
Copy link
Member

kulmann commented Jul 1, 2022

@kulmann this is what we give:

Thanks, so the requirement is actually to just show a customizable welcome screen? No files related view needed as initial view, correct?

@labkode
Copy link
Member Author

labkode commented Jul 1, 2022

@kulmann correct, however access to Shares and Projects is still needed.

@kulmann
Copy link
Member

kulmann commented Jul 1, 2022

@kulmann correct, however access to Shares and Projects is still needed.

Thats clear. Was just referring to the initial view :-)

@labkode
Copy link
Member Author

labkode commented Jul 1, 2022

Work in progress

@pmaier1
Copy link

pmaier1 commented Jul 8, 2022

This feature is on the roadmap for 2022 (after GA). It basically boils down to two parts
a) A user invitation workflow (1. using integrated LDAP, 2. using external IDP provisioning API)
b) A user role "Guest" that does incorporate the respective permission set (e.g., "owns a personal space")

@kulmann
Copy link
Member

kulmann commented Jul 8, 2022

From my point of view we can treat the lightweight accounts like normal User-role users in ocis. Backend side we'd need to make sure that the lightweight accounts don't have a drive of type personal in the /me/drives response. If we can make that possible we can implement in web that the Personal nav item would be omitted and instead show a welcome page with customizable content (via theme.json).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants