Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CERN: User defined notifications #2971

Open
labkode opened this issue Jun 14, 2022 · 7 comments
Open

CERN: User defined notifications #2971

labkode opened this issue Jun 14, 2022 · 7 comments

Comments

@labkode
Copy link
Member

labkode commented Jun 14, 2022

Ability to set a notification workflow for specific files/directories to trigger a
mail to a specific e-group/person.

TODO(labkode): provide more info, Watcher in Dropbox

@micbar
Copy link
Member

micbar commented Jun 23, 2022

Building blocks are in place:

  1. Reva emits all file related events and sends it to the nats service in ocis (on the edge branch)
  2. Nats is bundled in ocis but could also be used with a dedicated system. Nats is an industry standard and needs to be scaled accordingly
  3. We have an implementation in ocis for an email messaging service. That could also be a push-notifications service.

@labkode
Copy link
Member Author

labkode commented Jul 1, 2022

For sending mails, a dedicated service will be created that reads from the event queue and dispatches them.

@micbar can you paste here an event payload that contains for example "new file created"?
I expect the payload to contain a path.

@labkode
Copy link
Member Author

labkode commented Jul 8, 2022

Can we have an example of a payload for a file created?

@labkode
Copy link
Member Author

labkode commented Jul 15, 2022

We'll implement in master based on the work in edge.
The big chunk of work is in the driver, so by respecting the interface of edge we'll be on the safe side when moving to edge.

@micbar
Copy link
Member

micbar commented Nov 10, 2022

@labkode What can we do here? This seems to be CERN todo.

@dragotin
Copy link
Contributor

To update from what was discussed on the workshop in Feb. 2023, the current implemented state is:

  • oCIS Edge comes with a notification service. Currently that sends emails on the following events:
    • Share created, share expiered
    • Space shared, space unshared, space membership expired

The email text can be customized for the site using templates as in https://github.com/owncloud/ocis/tree/master/services/notifications/pkg/email/templates - just copy the templates to a custom dir, change it and point the environment variable OCIS_EMAIL_TEMPLATE_PATH to it.

Additional CERN wishes:

  • Have a checkbox when creating a share to enable email notification to the receivers, default off.
  • Prevention that email is sent to too many people unintentionally ("Shared with group all"). This can be done
    • hardcoded: NEVER send emails to groups with more than 100 (or x) receivers
    • as an attribute of the group, ie. "never send email if shared with this group".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants